Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use logc instead of logx if possible #4610

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Jan 28, 2025

No description provided.

@kevwan kevwan force-pushed the feat/log-with-context branch from 131496c to 490ee4b Compare January 28, 2025 14:43
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (8690859) to head (490ee4b).
Report is 239 commits behind head on master.

Files with missing lines Patch % Lines
core/discov/publisher.go 33.33% 4 Missing ⚠️
core/discov/internal/registry.go 50.00% 3 Missing ⚠️
rest/internal/security/contentsecurity.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
rest/handler/authhandler.go 84.90% <100.00%> (ø)
rest/handler/breakerhandler.go 100.00% <100.00%> (ø)
rest/handler/contentsecurityhandler.go 100.00% <100.00%> (ø)
rest/handler/cryptionhandler.go 100.00% <100.00%> (ø)
rest/handler/sheddinghandler.go 100.00% <100.00%> (ø)
rest/httpx/responses.go 100.00% <100.00%> (ø)
.../internal/serverinterceptors/recoverinterceptor.go 100.00% <100.00%> (ø)
rest/internal/security/contentsecurity.go 78.31% <0.00%> (ø)
core/discov/internal/registry.go 86.96% <50.00%> (+8.06%) ⬆️
core/discov/publisher.go 65.78% <33.33%> (ø)

... and 7 files with indirect coverage changes

@kevwan kevwan merged commit ae09d0e into zeromicro:master Jan 28, 2025
5 of 6 checks passed
@kevwan kevwan deleted the feat/log-with-context branch January 28, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant